Fix Coverity Issues

This patches fixes below coverity issues 1> Waiting while holding a lock 2> Unused value Tracked-On: OAM-112450 Signed-off-by: Padmashree Mandri <[email protected]>
projectceladon · Feb 20, 2024 · 280f447 · 280f447
1 parent a4a679c
commit 280f447
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/primary/audio_hw.c b/primary/audio_hw.c
@@ -1021,11 +1021,11 @@ static ssize_t in_read(struct audio_stream_in *stream, void* buffer,
         memset(buffer, 0, bytes);
 
 exit:
+    pthread_mutex_unlock(&in->lock);
     if (ret < 0)
         usleep(bytes * 1000000 / audio_stream_in_frame_size(stream) /
                in_get_sample_rate(&stream->common));
 
-    pthread_mutex_unlock(&in->lock);
     return bytes;
 }
 

diff --git a/usb/audio_hal.c b/usb/audio_hal.c
@@ -709,7 +709,6 @@ static int adev_open_output_stream(struct audio_hw_device *hw_dev,
         proxy_config.rate = config->sample_rate;
     } else {
         proxy_config.rate = config->sample_rate = profile_get_default_sample_rate(out->profile);
-        ret = -EINVAL;
     }
 
     out->adev->device_sample_rate = config->sample_rate;