feat: implement flat_answer_map #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winged
requested changes
Oct 19, 2023
caluma/caluma_form/models.py
Outdated
| @property | ||
| def flat_answer_map(self): |
There was a problem hiding this comment.
I'd rather have this as a method, not a @property. Just to make clear to the caller that this does stuff. Also, because multiple calls to the property will re-evaluate the code.
And a docstring would be nice too
StephanH90
force-pushed
the
feat/flat-answer-map
branch
from
0516a7c
to
f393c30
Compare
StephanH90
force-pushed
the
feat/flat-answer-map
branch
from
f393c30
to
8d96071
Compare
StephanH90
force-pushed
the
feat/flat-answer-map
branch
from
8d96071
to
d96d33e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
flat_answer_mapproperty to a document which can be used in the same was as we do it inember_caluma.