Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filters): add EXACT_WORD lookup type to SearchAnswer #2076

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat(filters): add EXACT_WORD lookup type to SearchAnswer #2076

merged 1 commit into from
Sep 27, 2023

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Sep 25, 2023

No description provided.

@czosel czosel requested a review from winged September 25, 2023 12:12
winged
winged approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A test case would have been nice, but I think the code is solid, and a test case for this specific lookup type might also be overkill

@czosel czosel force-pushed the feat-search-answer-exact-lookup branch from b8790b4 to 23c0e55 Compare September 27, 2023 07:03
@winged winged merged commit 70e875c into main Sep 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czosel @winged