-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move current namespace logic to config #675
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kevin <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Kevin this looks really good. Is it cool if you update this to work with the refactored project?
Perhaps get_current_namespace
should live in kube_api_helpers WDYT?
Perhaps kube_api_helpers doesnt work as there could be a circular import. I say this because as we add more modules e.g. KFT Training Client we would probably prefer common functions like this to live there? WDYT? |
I'll take a look at finding a better place for this. A |
What changes have been made
I was running into some issues testing locally without specifying a namespace. I realized we could default early and make the error much clearer
Verification steps
Use the codeflare_sdk in a jupyter nb locally and don't specify namespace in your cluster configuration
Checks