Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New variant functions instead of pseudo class methods for init methods #192

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

progrium
Copy link
Owner

This is a significant change that impacts commonly used convenience constructor methods. These new ones are more Go idiomatic, don't get in the way of actual class methods with the same name, and actually call Autorelease to honor the memory management policy. You now need to use objc.Retain in some cases where you might have gotten away with not.

@progrium progrium requested a review from tmc August 21, 2023 04:32
Copy link
Collaborator

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some treatment of Retain() in docs will make sense but this looks like a move in the right direction. LGTM.

@progrium progrium merged commit 682f17d into main Aug 21, 2023
3 checks passed
@progrium progrium deleted the new-variants branch August 23, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants