Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleQuery improvements #41

Merged
merged 10 commits into from
Jul 7, 2023
Merged

SimpleQuery improvements #41

merged 10 commits into from
Jul 7, 2023

Conversation

guillaumemichel
Copy link
Contributor

@guillaumemichel guillaumemichel commented Jun 30, 2023 •
edited
Loading

Major features of this large PR:

  • Cleaning up the SimpleQuery module
  • Added 100% test coverage for the SimpleQuery module
  • Small changes introduced in other modules to make sure their interface can be used by Query implementations
  • Completed test coverage of other modules
  • Fix flaky tests in the libp2pendpoint module
  • Addressing Query peerlist should contain network addresses #38

@guillaumemichel guillaumemichel self-assigned this Jul 4, 2023
@guillaumemichel
Copy link
Contributor Author

f96ac6f is addressing #38

@guillaumemichel guillaumemichel mentioned this pull request Jul 4, 2023
Closed
@guillaumemichel guillaumemichel marked this pull request as ready for review July 4, 2023 15:43
@guillaumemichel guillaumemichel marked this pull request as draft July 4, 2023 15:43
@guillaumemichel guillaumemichel linked an issue Jul 6, 2023 that may be closed by this pull request
Query peerlist should contain network addresses #38
Closed
@guillaumemichel guillaumemichel marked this pull request as ready for review July 6, 2023 21:34
@guillaumemichel
Copy link
Contributor Author

The CI has been run many times, and everything is green. This is good to merge.

@guillaumemichel guillaumemichel requested a review from iand July 7, 2023 05:44
@guillaumemichel
Kadkey remove errors (#56)
65a4215 
* fixed libp2pendpoint flaky tests

* removed errors from KadKey operations
@iand iand merged commit 9246f76 into main Jul 7, 2023
16 checks passed
@iand iand deleted the feat/improve-simplequery branch July 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iand iand Awaiting requested review from iand iand is a code owner

Assignees

@guillaumemichel guillaumemichel

Labels
None yet
Projects
DHT Optimization
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query peerlist should contain network addresses
2 participants
@guillaumemichel @iand