-
Notifications
You must be signed in to change notification settings - Fork 48
Linted some parts of code #327
base: master
Are you sure you want to change the base?
Conversation
It is always good practice to declare all variables first and then use them
You will want to target the develop branch for most PR's. Some of these issues may have already been addressed there. |
@irdan but these are being mentioned in code climate which is suggested by privly in documentation to follow for bug tracing |
Development targets the |
@smcgregor hey should I focus on develop branch to contribute to this project and my pull request can't it be accepted ? |
Yes, all contributions should be made against the |
@nikhilponnuru If you want this PR to be accepted, you should close it and open a new one against the develop branch. Thanks! |
used global directives to avoid warnings and errors shown by jshint and jslint
changed way of accessing object properties
used concept of javascript hoisting and declared variable -'messaging' before it is used [as it is the recommended practice ]