Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update debugging explainer with debugging data #157

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

xinggao01
Copy link
Contributor

No description provided.

@jasarora-google
Copy link
Collaborator

Should we add the BYOB logging details here as well?

Copy link
Collaborator

@akshaypundle akshaypundle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add a few more comments .. but publishing these for now.

debugging_protected_audience_api_services.md Outdated Show resolved Hide resolved
debugging_protected_audience_api_services.md Show resolved Hide resolved
debugging_protected_audience_api_services.md Outdated Show resolved Hide resolved
debugging_protected_audience_api_services.md Outdated Show resolved Hide resolved
debugging_protected_audience_api_services.md Outdated Show resolved Hide resolved
debugging_protected_audience_api_services.md Outdated Show resolved Hide resolved
@xinggao01
Copy link
Contributor Author

Should we add the BYOB logging details here as well?

How that works? it should work in same way as existing UDF logs?

@chatterjee-priyanka
Copy link
Collaborator

BYOB logging should be a follow up update after full details are internally finalized.


Each server has `PS_VERBOSITY` flag, which sets the verbosity level of the output logs. A higher verbosity will give more logging data, but can also slow down request processing. This is especially relevant in `non_prod` builds because there can be large volume of request logs. At high QPS, we recommend setting `PS_VERBOSITY` `<=3`.

2. Event message
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this "Request/Response export"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be others in the Event message, like udf log and kv signal.

debugging_protected_audience_api_services.md Outdated Show resolved Hide resolved
This is a [structured proto message](https://github.com/privacysandbox/bidding-auction-servers/blob/e40a4fccdce168379189ab7b6b87b55b1e3f736d/api/bidding_auction_servers.proto#L1582) to include the API proto object.
It is written to cloud storage through Open Telemetry log collector([example config](https://github.com/privacysandbox/bidding-auction-servers/blob/main/production/deploy/gcp/terraform/services/autoscaling/collector_startup.tftpl)) for [AdTech consented debugging](#adtech-consented-debugging).

3. Adtech UDF Log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shoul dmention which UDFs in the text below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should include all the UDFs


3. Adtech UDF Log

This is the log from javascript `console.log`. They are only exported for [AdTech consented debugging](#adtech-consented-debugging), through both Request logs and Event message.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Request log in this context? Is it system log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is mentioned above under "Verbose logs" - Log types - Request logs

@akshaypundle
Copy link
Collaborator

Sorry, I think I got a bit confused by request log. So, we are saying that we have:

  1. System level logs
  2. Request level logs
  3. Request/Response structured output
  4. UDF log
  5. debug info in response

Do you think we should try to clarify the difference between 2) and 3)? I know you called 3) as "Event message" in your original documentation...

@xinggao01
Copy link
Contributor Author

Sorry, I think I got a bit confused by request log. So, we are saying that we have:

  1. System level logs
  2. Request level logs
  3. Request/Response structured output
  4. UDF log
  5. debug info in response

Do you think we should try to clarify the difference between 2) and 3)? I know you called 3) as "Event message" in your original documentation...

we can clarify with this:
2) is the un-structured verbose log triggered by a request
3) is the structured proto trigger by a request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants