Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dev into main #41

Merged
merged 21 commits into from
Aug 22, 2023
Merged

Merge dev into main #41

merged 21 commits into from
Aug 22, 2023

Conversation

maudnals
Copy link
Collaborator

@maudnals maudnals commented Aug 22, 2023 •
edited
Loading

Merge dev into main.

  • Unification of simple and advanced mode
  • RMSPE to RMSRE
  • Update budget split and conversion count for Key strategy B

cucuandreea and others added 21 commits May 11, 2023 13:32
@cucuandreea @maudnals
Update budget split and conversions count for Key Strategy 'B' (#33)
29a104c 
* Fix budget split for less granular key

* Remove logging

* Adjust average conversions/bucket based on key structure for key strategy B

* Add warning for budget split evenly between less granular keys

* cleanup unused code

* Add validation for budget split for key strategy B

* Update public/index.html

Co-authored-by: Maud <[email protected]>

* Bump version

---------

Co-authored-by: Maud <[email protected]>
@cucuandreea
Change RMSPE to RMSRE (#35)
05d2550 
* Change RMSPE to RMSRE

* Bump version; Change percentage variable name to isPercentage
@maudnals
Feat: Updated epsilon default
4e78ee2
@maudnals
Merge pull request #36 from privacysandbox/maudnals-epsilon
4bdafde 
Updated epsilon
@maudnals
Refactor: unified clearAll functions across modes
d7dc074
@maudnals
Refactor: Unified display intialization functions
3265218
@maudnals
Chore: Bumped version number
452e706
@maudnals
Refactor: removed unneeded arg
120b9c3
@maudnals
Bugfix: Fixed bug where empty state remained
d793c95
@maudnals
Merge pull request #37 from privacysandbox/n-refactor-unify-modes
cc93761 
Refactor: Unify simple and advanced modes (Steps 1A)
@maudnals
Refactor: renaming to noiseless
b3eb22f
@maudnals
Refactor: Used new simulation object structure
c8f3159
@maudnals
Refactor: Minor renaming
74a7ff7
@cucuandreea
rename laplace.js
06aae4d
@cucuandreea
Unify simulation logic between the two modes
f5629a8
@cucuandreea
fix download all
d8097b2
@cucuandreea
bump version number
1f36502
@maudnals
Reactor, Bugfixes: see #38 (comment)
a8e3d74
@cucuandreea
Fix extra decimals for summary laues; fix reset for measurement goals
2529823
@cucuandreea
Delete unused functions
75d6b91
@maudnals
Merge pull request #38 from privacysandbox/1b-refactor-unify-modes
04eede4 
Refactor: Unify simple and advanced modes (Steps 1B)
@maudnals maudnals merged commit d8f9a1b into main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cucuandreea cucuandreea cucuandreea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maudnals @cucuandreea