fix: Import PR 13: Use empty object as default device signals for And…

…roid clients [Buyer code wrapper](https://github.com/privacysandbox/bidding-auction-servers/blob/v3.6.0/services/bidding_service/code_wrapper/buyer_code_wrapper.h#L36) adds `wasmHelper` to `device_signals` `generateBid` parameter but it did not work when it was a string. GITHUB_PR_URL=#13 GitOrigin-RevId: ab42e11 Change-Id: Icff17531dedea436a61ca6c2fca3336c26ea4918
privacysandbox · May 8, 2024 · 1c32ad4 · 1c32ad4
1 parent 2903295
commit 1c32ad4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/services/bidding_service/generate_bids_reactor.cc b/services/bidding_service/generate_bids_reactor.cc
@@ -115,7 +115,7 @@ constexpr char kJsonStringValueStart[] = R"JSON(":")JSON";
 constexpr char kJsonValueStart[] = R"JSON(":)JSON";
 constexpr char kJsonValueEnd[] = R"JSON(,")JSON";
 constexpr char kJsonEmptyString[] = R"JSON("")JSON";
-constexpr char kEmptyDeviceSignals[] = R"JSON("{}")JSON";
+constexpr char kEmptyDeviceSignals[] = R"JSON({})JSON";
 
 std::string MakeBrowserSignalsForScript(absl::string_view publisher_name,
                                         absl::string_view seller,

diff --git a/services/bidding_service/generate_bids_reactor_test.cc b/services/bidding_service/generate_bids_reactor_test.cc
@@ -767,7 +767,7 @@ TEST_F(GenerateBidsReactorTest, GeneratesBidDespiteNoBrowserSignals) {
         IGForBidding received;
         EXPECT_EQ(*input[3], expected_signals);
         // Check that device signals are an empty JSON object.
-        EXPECT_EQ(*input[4], R"JSON("{}")JSON");
+        EXPECT_EQ(*input[4], R"JSON({})JSON");
         return FakeExecute(batch, std::move(batch_callback), response_json);
       });
   RawRequest raw_request;