Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renew gemeente key #131

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

MartijnvDijk
Copy link
Contributor

No description provided.

Copy link

No issues were found when running irma scheme verify. The status checks fail because the changes are not signed yet. This will be resolved by the Yivi team when your changes have been approved. You don't have to deal with this yourself.

@DibranMulder
Copy link

We are reaching out to you with your known contact details, so that we are sure this is the Gemeente Nijmegen.

DibranMulder
DibranMulder previously approved these changes Oct 21, 2024
Copy link

@DibranMulder DibranMulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the following:

  • Counter has right value.
  • Expiry date is in 1 year.
  • <n> length is 617
  • Verified SHA256 hash on the phone db2...de1

@confiks
Copy link
Contributor

confiks commented Oct 21, 2024

Here's another public key with the SHA256-sum db2...de1 😉: not-5.txt

Another check for your list: There should be enough bases in the public key; at least the amount of attributes in the biggest credential of the issuer, plus two more bases for the secret key and metadata attribute. Which is the case with the public key in this PR.

@ivard
Copy link
Member

ivard commented Oct 22, 2024

Here's another public key with the SHA256-sum db2...de1 😉: not-5.txt

Another check for your list: There should be enough bases in the public key; at least the amount of attributes in the biggest credential of the issuer, plus two more bases for the secret key and metadata attribute. Which is the case with the public key in this PR.

Luckily, irma scheme verify checks for this automatically nowadays, so we don't have to manually check the number of bases anymore.

Copy link

No issues were found when running irma scheme verify.

@ivard ivard merged commit ff79548 into privacybydesign:master Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants