Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yivi key renewal #126

Closed
wants to merge 3 commits into from
Closed

Conversation

MartijnvDijk
Copy link
Contributor

No description provided.

Copy link

No issues were found when running irma scheme verify.

Copy link
Member

@ivard ivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You placed a PublicKeys directory in the root of the project. This is not going to work. It should be placed in the issuer directory: issuerid/PublicKeys/x.xml. The x should be replaced with the previous public key id incremented by 1. No previous public keys should be removed.

More information can be found here: https://irma.app/docs/schemes/

Copy link

No issues were found when running irma scheme verify. The status checks fail because the changes are not signed yet. This will be resolved by the Yivi team when your changes have been approved. You don't have to deal with this yourself.

Copy link

No issues were found when running irma scheme verify. The status checks fail because the changes are not signed yet. This will be resolved by the Yivi team when your changes have been approved. You don't have to deal with this yourself.

@MartijnvDijk MartijnvDijk requested a review from ivard April 30, 2024 09:06
@ivard
Copy link
Member

ivard commented Apr 30, 2024

I checked your current key (4.xml) and it only expires November 1st 2024. We extended the expiry dates a bit last year to reduce operational work in the transition period. Are you aware of this?

@MartijnvDijk
Copy link
Contributor Author

No, we were not aware of this. We would like te renew the key early this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants