Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Recent Activity on the Home screen #126

Open
thomasvandeweijer opened this issue Mar 10, 2023 · 2 comments
Open

Inconsistent Recent Activity on the Home screen #126

thomasvandeweijer opened this issue Mar 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@thomasvandeweijer
Copy link

What I expect to happen

For the Home screen to have a consistent number of Recent Activity entries (for example, the last 4)

What happened instead

On the Home screen under Recent Activity it first shows 4 activities when opening the app, but when switching back to Home screen after already being in the app it shows 2 activities instead.

How to reproduce

  • Make sure there's more than 4 entries in the Activity tab in your app
  • Close the app and remove it from your "recent apps"
  • Open the app fresh
  • It will now display 4 entries under Recent Activity
  • Switch to any other tab and back to Home
  • It will now only display 2 entries under Recent Activity

Hard and software

  • App version: 7.0.1 (419445, fa2ebd5)
  • Android version: 12
  • Device: OnePlus 7T Pro
@ivard ivard added the bug Something isn't working label Mar 14, 2023
@ivard
Copy link
Member

ivard commented Mar 17, 2023

The expected behaviour is that it should always show the 2 most recent activities. So apparently something goes wrong in the case where this list gets updated when a new activity occurs.

@ivard
Copy link
Member

ivard commented Oct 11, 2023

The pattern that we use in the HistoryRepository currently makes it hard to resolve this issue. In retrospect the repository pattern is not really suitable there. Therefore, the class should be refactored to a bloc and in the new implementation this bug should be taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants