Fix/update documentation #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivard
requested changes
Jul 20, 2022
| 1. Start IRMA server (in the root directory of this project) | ||
| ```bash | ||
| ~/go/bin/irma server --static-path ./webapp/build | ||
| ``` |
There was a problem hiding this comment.
go install should add the binary to your PATH too, at least that's the case with me.
There was a problem hiding this comment.
do we want to document that step or can we expect either the package manager or the reader to take care of that?
There was a problem hiding this comment.
If you installed Go in a way that the ~/go/bin was not added to your PATH automatically, then it's probably better to either mention this or keep it the way you did it now.
ivard
reviewed
Jul 20, 2022
README.md
Outdated
| }; | ||
| EOD | ||
| ) | ||
| cp webapp/config.example.js build/assets/config.js | ||
| cp -a webapp/ src/main/ |
There was a problem hiding this comment.
I think that final step is not needed to copy webapp to src/main, because the Java-part does not need it.
There was a problem hiding this comment.
without the copy:
$ gradle appRun
> Task :appRun
You're running webapp in hard inplaceMode: Overlay and filtering features of gretty will be disabled!
11:21:35 WARN Web application not found /tmp/irma_email_issuer/src/main/webapp
11:21:35 WARN Failed startup of context o.a.g.JettyWebAppContext@5a709816{/irma_email_issuer,null,null}{/tmp/irma_email_issuer/src/main/webapp}
java.io.FileNotFoundException: /tmp/irma_email_issuer/src/main/webapp
ivard
reviewed
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.