This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
[WIP] Refactor/#499 clean up duplicated KeccakTable #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #499. The PR currently replaces duplicated
KeccakTable
inwithdrawal_circuit.py
,tx_circuit.py
, andpi_circuit.py
withKeccakTable
fromutil/tables.py
.However, it seems there is still duplication in
evm_circuit/table.py
andevm_circuit/typing.py
that defineKeccakTableRow
andKeccakCircuit
.The only difference between the two is the former has
is_enabled
binary first column and the latter hasstate_tag
first column that is set to2
showing that this row is the final part of a variable-length input.should I try to combine the two?