Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Conversation

mmjahanara
Copy link

@mmjahanara mmjahanara commented Feb 18, 2024

WIP for #499. The PR currently replaces duplicated KeccakTable in withdrawal_circuit.py, tx_circuit.py, and pi_circuit.py with KeccakTable from util/tables.py.

However, it seems there is still duplication in evm_circuit/table.py and evm_circuit/typing.py that define KeccakTableRow and KeccakCircuit.

The only difference between the two is the former has is_enabled binary first column and the latter has state_tag first column that is set to 2 showing that this row is the final part of a variable-length input.

should I try to combine the two?

@ed255 ed255 linked an issue Feb 22, 2024 that may be closed by this pull request
@ChihChengLiang
Copy link
Collaborator

Hi @mmjahanara,

We're sorry for deprecating the Python implementation and we'll stop taking pull requests. The reason for deprecation is described in #518.

Thanks for looking into the issue #499. It must take you quite some time to look into the issue, find the duplications KeccakTable, and think about how to merge the tables. We're sorry the deprecation discussion happened in the middle of this pull request.

We still have some more unclaimed good first issues on the zkevm-circuits repo. Feel free to take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: clean up duplicated keccak_table
2 participants