Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

markdown spec for invalid_creation_code error #400

Closed
wants to merge 5 commits into from
Closed

markdown spec for invalid_creation_code error #400

wants to merge 5 commits into from

Conversation

DreamWuGit
Copy link
Collaborator

@DreamWuGit DreamWuGit mentioned this pull request Mar 13, 2023
Merged
1 task
@DreamWuGit DreamWuGit marked this pull request as ready for review March 14, 2023 08:58
@ed255 ed255 requested a review from hero78119 April 13, 2023 11:13
@ed255 ed255 requested a review from leolara April 27, 2023 12:01
@ChihChengLiang
Copy link
Collaborator

pending on the circuit PR privacy-scaling-explorations/zkevm-circuits#1292

@ChihChengLiang
Copy link
Collaborator

@silathdiir is this PR ready for review?

@silathdiir
Copy link
Contributor

Yes, thanks. And also the related circuit PR privacy-scaling-explorations/zkevm-circuits#1292.

Please help review when you have time. Thanks.

@ChihChengLiang
Copy link
Collaborator

Pending updates from @silathdiir as the circuit pr review suggests privacy-scaling-explorations/zkevm-circuits#1292 (review)

github-merge-queue bot pushed a commit to privacy-scaling-explorations/zkevm-circuits that referenced this pull request Jul 7, 2023
@DreamWuGit @silathdiir
circuit for invalid creation code (#1292)
3733326 
### Description

circuit for invalid creation code error in create, markdown spec
privacy-scaling-explorations/zkevm-specs#400
### Issue Link

issue #1291 

### Type of change

- [x] New feature (non-breaking change which adds functionality)

### Rationale

Get first byte of code to store , check it is 0xef

This PR contains:
- buss mapping: at the return opcode in create, get the first byte .
- add circuit & test 
- add tx deploy trace test .

---------

Co-authored-by: Steven Gu <[email protected]>
@ed255
Copy link
Member

ed255 commented Jul 13, 2023

@silathdiir kindly ping to remind about updating this spec according to the merged circuit PR. Let us know if you need help with anything!

@silathdiir
Copy link
Contributor

@silathdiir kindly ping to remind about updating this spec according to the merged circuit PR. Let us know if you need help with anything!

Sorry for delay. Will try to continue on this PR in this month (add invalid_creation_code spec code and update return_revert spec).

This was referenced Jul 25, 2023
Closed
Closed
Merged
@KimiWu123
Copy link
Contributor

moved to #478

@KimiWu123 KimiWu123 closed this Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hero78119 hero78119 Awaiting requested review from hero78119

@leolara leolara Awaiting requested review from leolara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The InvalidCreationCode Error
5 participants
@DreamWuGit @ChihChengLiang @silathdiir @ed255 @KimiWu123