This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 857
[proof chunk] [WIP] [testing] fix various issue found in integration test #1773
Merged
hero78119
merged 16 commits into
privacy-scaling-explorations:proof-chunk
from
hero78119:fix_padding
Mar 1, 2024
Merged
[proof chunk] [WIP] [testing] fix various issue found in integration test #1773
hero78119
merged 16 commits into
privacy-scaling-explorations:proof-chunk
from
hero78119:fix_padding
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
Issues related to the bus-mapping workspace member
crate-zkevm-circuits
Issues related to the zkevm-circuits workspace member
T-bench
Type: benchmark improvements
crate-circuit-benchmarks
Issues related to the circuit-benchmarks workspace member
crate-integration-tests
Issues related to the integration-tests workspace member
labels
Feb 21, 2024
hero78119
force-pushed
the
fix_padding
branch
from
February 21, 2024 08:47
0284a4c
to
ab43142
Compare
hero78119
changed the title
[proof chunk][testing] rewrite logic to support rw_table padding
[proof chunk][testing] fix various issue found in integration test
Feb 22, 2024
hero78119
changed the title
[proof chunk][testing] fix various issue found in integration test
[proof chunk] [WIP] [testing] fix various issue found in integration test
Feb 22, 2024
hero78119
force-pushed
the
fix_padding
branch
from
February 22, 2024 07:56
3bb1468
to
46d5437
Compare
hero78119
force-pushed
the
fix_padding
branch
2 times, most recently
from
February 23, 2024 14:38
155e056
to
cd6c843
Compare
hero78119
force-pushed
the
fix_padding
branch
from
February 23, 2024 14:42
cd6c843
to
a7802e0
Compare
hero78119
force-pushed
the
fix_padding
branch
from
February 24, 2024 16:06
c0f0495
to
d65af2f
Compare
hero78119
force-pushed
the
fix_padding
branch
3 times, most recently
from
February 29, 2024 02:17
73604a9
to
4870080
Compare
hero78119
force-pushed
the
fix_padding
branch
from
February 29, 2024 07:40
4870080
to
f5577c6
Compare
github-actions
bot
added
the
CI
Issues related to the Continuous Integration mechanisms of the repository.
label
Feb 29, 2024
hero78119
force-pushed
the
fix_padding
branch
from
February 29, 2024 07:51
f5577c6
to
1008eb3
Compare
hero78119
force-pushed
the
fix_padding
branch
from
February 29, 2024 09:19
1008eb3
to
418f37b
Compare
github-actions
bot
removed
the
CI
Issues related to the Continuous Integration mechanisms of the repository.
label
Mar 1, 2024
All checked pass, will merge to feature branch and having the review in another PR |
hero78119
merged commit Mar 1, 2024
0ab41c9
into
privacy-scaling-explorations:proof-chunk
15 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
crate-bus-mapping
Issues related to the bus-mapping workspace member
crate-circuit-benchmarks
Issues related to the circuit-benchmarks workspace member
crate-integration-tests
Issues related to the integration-tests workspace member
crate-zkevm-circuits
Issues related to the zkevm-circuits workspace member
T-bench
Type: benchmark improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Reported issues found on multi-chunk testing
rw_counter
inpadding
, and rely on permutation constraints on by-address/chronological rw_table to avoid malicious padding insert.Related Issue
To close #1778