Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[feat] support EIP 1559/2930 in testool #1762

Conversation

lightsing
Copy link
Contributor

@lightsing lightsing commented Feb 8, 2024

Description

This pr enables support of EIP 1559/2930 in testool

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor (no updates to logic)

@github-actions github-actions bot added the crate-eth-types Issues related to the eth-types workspace member label Feb 8, 2024
@ChihChengLiang ChihChengLiang linked an issue Feb 8, 2024 that may be closed by this pull request
@github-actions github-actions bot added the crate-external-tracer Issues related to the external-tracer workspace member label Mar 26, 2024
@github-actions github-actions bot added the crate-geth-utils Issues related to the geth-utils workspace member label Mar 27, 2024
@lightsing lightsing marked this pull request as ready for review March 27, 2024 04:20
@lispc
Copy link
Collaborator

lispc commented Mar 27, 2024

Remove wip in title?

@github-actions github-actions bot added the crate-mock Issues related to the mock workspace member label Apr 1, 2024
@lightsing
Copy link
Contributor Author

FYI, another noticeable thing is test evm_circuit::execution::end_tx::test::end_tx_gadget_nonexisting_coinbase fails when log level is higher than DEBUG cuz check_rw_lookup panics. Same issue happens on main branch. I didn't check whether there are more cases have same issue.

Self::check_rw_lookup(
&assigned_stored_expressions,
step,
block,
chunk,
region.challenges(),
);

@lispc
Copy link
Collaborator

lispc commented Apr 1, 2024

FYI, another noticeable thing is test evm_circuit::execution::end_tx::test::end_tx_gadget_nonexisting_coinbase fails when log level is higher than DEBUG cuz check_rw_lookup panics. Same issue happens on main branch. I didn't check whether there are more cases have same issue.

Self::check_rw_lookup(
&assigned_stored_expressions,
step,
block,
chunk,
region.challenges(),
);

OK at least this pr does not make thing worse

@lightsing lightsing changed the title [wip] [feat] support EIP 1559/2930 in testool [feat] support EIP 1559/2930 in testool Apr 1, 2024
@lightsing
Copy link
Contributor Author

@ChihChengLiang ready for review

@ChihChengLiang ChihChengLiang self-requested a review April 1, 2024 09:00
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @lightsing for upstreaming the testool!

@KimiWu123 KimiWu123 self-requested a review April 2, 2024 00:16
Copy link
Contributor

@KimiWu123 KimiWu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Apr 3, 2024
Merged via the queue into privacy-scaling-explorations:main with commit 82e8d8f Apr 3, 2024
15 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-eth-types Issues related to the eth-types workspace member crate-external-tracer Issues related to the external-tracer workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-mock Issues related to the mock workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(testool): support eip2930 / eip1559 txs
4 participants