This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
handle gas uint overflow (ErrorGasUintOverflow) #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-zkevm-circuits
|
Hi @DreamWuGit , we decided to handle |
DreamWuGit
force-pushed
the
gas_uint_overflow
branch
from
1db3850
to
1d267b6
Compare
…evm-circuits into gas_uint_overflow
|
@ChihChengLiang @KimiWu123 can have a look now. |
ChihChengLiang
approved these changes
Sep 12, 2023
| let common_error_gadget = CommonErrorGadget::construct( | ||
| cb, | ||
| opcode.expr(), | ||
| 11.expr() + is_call.expr() + is_callcode.expr(), |
There was a problem hiding this comment.
I noticed we fall back to manual offset counting here. Is it because cb.rw_counter_offset() doesn't work here?
There was a problem hiding this comment.
no, it works, but I feel cb.rw_counter_offset() is indirect way for calculating the rw offset. we can not know how the rwc change by reading the code directly, it is always right. I prefer old way of it. so keep it when i touch it.
There was a problem hiding this comment.
issue #1599 for discussion .
zkevm-circuits/src/evm_circuit/execution/error_oog_memory_copy.rs
Outdated
Show resolved
Hide resolved
zkevm-circuits/src/evm_circuit/execution/error_oog_memory_copy.rs
Outdated
Show resolved
Hide resolved
zkevm-circuits/src/evm_circuit/execution/error_oog_memory_copy.rs
Outdated
Show resolved
Hide resolved
Merged
via the queue into
privacy-scaling-explorations:main
with commit Sep 13, 2023
c67b4e8
13 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently ErrorGasUintOverflow is handled within normal OOG cases, so distribute ErrorGasUintOverflow checking within each OOG gadgets (oog sha3, oog static/dynamic memory expansion, oog log etc.)
the
MemoryExpandedAddressGadgetis responsible for overflow status.Issue Link
[link issue here]
Type of change
How Has This Been Tested?
all tests pass
This PR contains: