rm must_create

privacy-scaling-explorations · Feb 22, 2024 · af62f15 · af62f15
1 parent 07ecfe0
commit af62f15
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/bus-mapping/src/circuit_input_builder/input_state_ref.rs b/bus-mapping/src/circuit_input_builder/input_state_ref.rs
@@ -624,7 +624,14 @@ impl<'a> CircuitInputStateRef<'a> {
                 value_prev: sender_balance_prev,
             },
         )?;
-        self.transfer_to(step, receiver, receiver_exists, opcode_is_create, value, true)?;
+        self.transfer_to(
+            step,
+            receiver,
+            receiver_exists,
+            opcode_is_create,
+            value,
+            true,
+        )?;
 
         Ok(())
     }

diff --git a/zkevm-circuits/src/evm_circuit/execution/begin_tx.rs b/zkevm-circuits/src/evm_circuit/execution/begin_tx.rs
@@ -467,14 +467,13 @@ impl<F: Field> ExecutionGadget<F> for BeginTxGadget<F> {
         let callee_exists =
             is_precompiled(&tx.to_or_contract_addr()) || !callee_code_hash.is_zero();
         let caller_balance_sub_fee_pair = rws.next().account_balance_pair();
-        let must_create = tx.is_create();
 
         let caller_balance_sub_value_pair = if !tx.value.is_zero() {
             rws.next().account_balance_pair()
         } else {
             (zero, zero)
         };
-        if !callee_exists && (!tx.value.is_zero() || must_create) {
+        if !callee_exists && (!tx.value.is_zero() || tx.is_create()) {
             callee_code_hash = rws.next().account_codehash_pair().1;
         }
         let callee_balance_pair = if !tx.value.is_zero() {