code cosmetics

zkevm-circuits/src/pi_circuit.rs

@@ -61,7 +61,7 @@ pub struct PiCircuitConfig<F: Field> {
     // The value can be one byte or multiple bytes. The order of values is pre-defined and
     // hardcode. can't use selector here because we need rotation
     q_rpi_value_start: Column<Fixed>,
-    // q_digest_field_start: mark starting of hi and low. can't use selector here because we need
+    // q_digest_value_start: mark starting of hi and low. can't use selector here because we need
     // rotation
     q_digest_value_start: Column<Fixed>,
 
@@ -1464,7 +1464,7 @@ impl<F: Field> SubCircuit<F> for PiCircuit<F> {
     /// Compute the public inputs for this circuit.
     fn instance(&self) -> Vec<Vec<F>> {
         let rpi_digest_byte_field =
-            get_rpi_digest_byte_field::<F>(self.max_txs, self.max_calldata, &self.public_data)
+            get_rpi_digest_byte_field_le::<F>(self.max_txs, self.max_calldata, &self.public_data)
                 .iter()
                 .rev()
                 .copied()
@@ -1774,7 +1774,7 @@ impl<F: Field> SubCircuit<F> for PiCircuit<F> {
 }
 
 /// Compute the raw_public_inputs column from the verifier's perspective.
-fn get_rpi_digest_byte_field<F: Field>(
+fn get_rpi_digest_byte_field_le<F: Field>(
     max_txs: usize,
     max_calldata: usize,
     public_data: &PublicData,

zkevm-circuits/src/super_circuit.rs

@@ -87,7 +87,6 @@ use std::array;
 pub struct SuperCircuitConfig<F: Field> {
     block_table: BlockTable,
     mpt_table: MptTable,
-    keccak_table: KeccakTable,
     evm_circuit: EvmCircuitConfig<F>,
     state_circuit: StateCircuitConfig<F>,
     tx_circuit: TxCircuitConfig<F>,
@@ -206,15 +205,14 @@ impl<F: Field> SubCircuitConfig<F> for SuperCircuitConfig<F> {
                 bytecode_table,
                 block_table: block_table.clone(),
                 copy_table,
-                keccak_table: keccak_table.clone(),
+                keccak_table,
                 exp_table,
             },
         );
 
         Self {
             block_table,
             mpt_table,
-            keccak_table,
             evm_circuit,
             state_circuit,
             copy_circuit,