remove rubycritic module

and all ruby test code Relates to #8749 Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann · Apr 27, 2022 · 13d107f · 13d107f
1 parent 48d2870
commit 13d107f
Show file tree

Hide file tree

Showing 14 changed files with 1 addition and 277 deletions.
diff --git a/README.md b/README.md
@@ -225,7 +225,6 @@ The layer can check on a recipe-level or on an image-level.
 | reconbf         | security audit tool                                   | https://github.com/HewlettPackard/reconbf                             |                                              |                        | x            |               |     |     |        |       |            |     |     | x      |     |          |         |          |          |               | x              |                  |             |
 | reuse           | Scan code for license information                     | https://github.com/fsfe/reuse-tool                                    |                                              |                        |              | x             |     |     |        |       |            |     |     |        |     |          |         |          |          | x             | x              |                  |             |
 | revive          | GO linter                                             | https://github.com/mgechev/revive                                     |                                              |                        |              | x             |     |     |        |       |            |     | x   |        |     |          |         |          |          |               |                | x                | x           |
-| rubycritic      | Ruby linter                                           | https://github.com/whitesmith/rubycritic/                             | meta-rubygems, manual enable                 |                        |              | x             |     |     |        |       |            |     |     |        |     |          |         |          |          | x             |                |                  | x           |
 | safety          | Check for known vulnerabilities in python-packages    | https://github.com/pyupio/safety                                      |                                              |                        |              | x             |     |     | x      |       |            |     |     |        |     |          |         |          | x        |               | x              |                  |             |
 | scancode        | Scan code for license information                     | https://github.com/nexB/scancode-toolkit                              |                                              |                        |              | x             |     |     |        |       |            |     |     |        |     |          |         |          |          | x             | x              |                  |             |
 | secretlint      | Tool to prevent committing credential                 | https://github.com/secretlint/secretlint                              | meta-oe, manual enable                       |                        | x            | x             |     |     |        |       |            |     |     |        |     |          |         |          |          | x             | x              |                  |             |
@@ -315,7 +314,6 @@ each tool does have it's own benefits and flaws so don't be mad if you have 10k+
     - [reconbf](docs/conf/module/reconbf.md)
     - [reuse](docs/conf/module/reuse.md)
     - [revive](docs/conf/module/revive.md)
-    - [rubycritic](docs/conf/module/rubycritic.md)
     - [safety](docs/conf/module/safety.md)
     - [scancode](docs/conf/module/scancode.md)
     - [secretlint](docs/conf/module/secretlint.md)

diff --git a/classes/sca-blacklist.bbclass b/classes/sca-blacklist.bbclass
@@ -53,7 +53,6 @@ SCA_BLACKLIST_pysymcheck ?= ""
 SCA_BLACKLIST_rats ?= ""
 SCA_BLACKLIST_reconbf ?= ""
 SCA_BLACKLIST_revive ?= "openssh"
-SCA_BLACKLIST_rubycritic ?= ""
 SCA_BLACKLIST_safety ?= ""
 SCA_BLACKLIST_scancode ?= ""
 SCA_BLACKLIST_secretlint ?= ""

diff --git a/classes/sca-global.bbclass b/classes/sca-global.bbclass
@@ -151,7 +151,6 @@ SCA_AVAILABLE_MODULES ?= "\
                         "
 # additional layer requirements
 SCA_AVAILABLE_MODULES[inspec] = "openembedded-layer rubygems"
-SCA_AVAILABLE_MODULES[rubycritic] = "rubygems"
 SCA_AVAILABLE_MODULES[secretlint] = "openembedded-layer"
 SCA_AVAILABLE_MODULES[standard] = "openembedded-layer"
 SCA_AVAILABLE_MODULES[stylelint] = "openembedded-layer"

diff --git a/classes/sca-on-recipe.bbclass b/classes/sca-on-recipe.bbclass
@@ -53,7 +53,6 @@ SCA_ENABLED_MODULES_RECIPE ?= "\
                             rats \
                             reuse \
                             revive \
-                            rubycritic \
                             safety \
                             scancode \
                             secretlint \

diff --git a/classes/sca-rubycritic.bbclass b/classes/sca-rubycritic.bbclass
diff --git a/docs/conf/module/rubycritic.md b/docs/conf/module/rubycritic.md
diff --git a/dynamic-distro/scatest/code-from-elsewhere/rubycritic-test_4.3.0.bb b/dynamic-distro/scatest/code-from-elsewhere/rubycritic-test_4.3.0.bb
diff --git a/files/module_list.csv b/files/module_list.csv
@@ -50,7 +50,6 @@ rats,Check on insecurities in several languages,https://github.com/redNixon/rats
 reconbf,security audit tool,https://github.com/HewlettPackard/reconbf,,,x,,,,,,,,,x,,,,,,,x,,
 reuse,Scan code for license information,https://github.com/fsfe/reuse-tool,,,,x,,,,,,,,,,,,,,x,x,,
 revive,GO linter,https://github.com/mgechev/revive,,,,x,,,,,,,x,,,,,,,,,x,x
-rubycritic,Ruby linter,https://github.com/whitesmith/rubycritic/,"meta-rubygems, manual enable",,,x,,,,,,,,,,,,,,x,,,x
 safety,Check for known vulnerabilities in python-packages,https://github.com/pyupio/safety,,,,x,,,x,,,,,,,,,,x,,x,,
 scancode,Scan code for license information,https://github.com/nexB/scancode-toolkit,,,,x,,,,,,,,,,,,,,x,x,,
 setuptoolslint,Lint python-setup.py,https://github.com/johnnoone/setuptools-pylint,,,,x,,,x,,,,,,,,,,,,,x,

diff --git a/recipes-sca-rules/sca-recipe-rubycritic-rules-native/files/fatal b/recipes-sca-rules/sca-recipe-rubycritic-rules-native/files/fatal
diff --git a/recipes-sca-rules/sca-recipe-rubycritic-rules-native/files/suppress b/recipes-sca-rules/sca-recipe-rubycritic-rules-native/files/suppress
diff --git a/...es-sca-rules/sca-recipe-rubycritic-rules-native/sca-recipe-rubycritic-rules-native_1.0.bb b/...es-sca-rules/sca-recipe-rubycritic-rules-native/sca-recipe-rubycritic-rules-native_1.0.bb
diff --git a/recipes-sca/rubycritic-sca-native/files/rubycritic.sca.description b/recipes-sca/rubycritic-sca-native/files/rubycritic.sca.description
diff --git a/recipes-sca/rubycritic-sca-native/rubycritic-sca-native_1.0.bb b/recipes-sca/rubycritic-sca-native/rubycritic-sca-native_1.0.bb
diff --git a/test/lang_metaruby.txt b/test/lang_metaruby.txt
@@ -1,2 +1 @@
-inspec
-rubycritic
+inspec