Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed log spacing #260

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fixed log spacing #260

merged 2 commits into from
Oct 16, 2024

Conversation

landinjm
Copy link
Contributor

  • Refactored parts setTimeStepList.cc to make it more readable.
  • If the number of outputs is set to 0, there are no outputs, regardless of the output type. Previously this was ignored for lists; however, the user should ignore the parameter and let PRISMS-PF use the default value of 10.
  • Added assertions for N_PER_DECADE so that the total increments is greater than 1.
  • The log spacing is working as intended. Note that our log spacing does not correspond to something like MATLAB's logspace because they begin at 10^0 while we start at 0.

Closes #157

@landinjm landinjm changed the base branch from master to development October 16, 2024 18:42
@landinjm landinjm merged commit 93687d2 into prisms-center:development Oct 16, 2024
2 checks passed
@landinjm landinjm deleted the fix_log_spacing branch October 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of outputs with LOG_SPACING setting
1 participant
@landinjm