ci: Report WASM size differences on pull requests #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM Size
|
SevInf
force-pushed
the
wasm-size-pr-comment
branch
from
a3c916a
to
a495650
Compare
Part of prisma/team-orm#666 Adds CI job that builds base branch and PR, compares their size and posts a comment. We could not reuse size-limit action we use for client since it's very JS centric.
SevInf
force-pushed
the
wasm-size-pr-comment
branch
from
a495650
to
49639e1
Compare
SevInf
changed the title
SevInf
requested review from
ospfranco and
laplab
and removed request for
a team
|
Ignore +23 MB increase in the comment, it was artificially inflated to test the action. Now, action does not run because of |
CodSpeed Performance ReportMerging #4561 will not alter performanceComparing Summary
|
Jolg42
reviewed
Dec 13, 2023
miguelff
approved these changes
Dec 13, 2023
Jolg42
reviewed
Dec 13, 2023
Co-authored-by: Joël Galeran <[email protected]>
Co-authored-by: Joël Galeran <[email protected]>
Jolg42
reviewed
Dec 13, 2023
Jolg42
reviewed
Dec 13, 2023
Jolg42
reviewed
Dec 13, 2023
|
This looks good once at least Joel's comment on the path ignore is addressed. |
Jolg42
reviewed
Dec 13, 2023
Co-authored-by: Joël Galeran <[email protected]>
Co-authored-by: Joël Galeran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/prisma/team-orm/issues/666
Adds CI job that builds base branch and PR, compares their size and
posts a comment. We could not reuse size-limit action we use for client
since it's very JS centric.