Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driver-adapters: remove dispose method for JS transaction interface #4489

Merged
merged 9 commits into from
Nov 27, 2023
Merged

driver-adapters: remove dispose method for JS transaction interface #4489

merged 9 commits into from
Nov 27, 2023

Commits on Nov 23, 2023

  1. driver-adapters: remove dispose method for JS transaction interface 

    Remove the boilerplate `Transaction.dispose` method from the public
driver adapter interface and move the corresponding functionality
directly to the destructor of `TransactionProxy`.

Refs: #4286
Closes: prisma/team-orm#391
    @aqrln
    aqrln committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4103f85 View commit details
    Browse the repository at this point in the history

  2. Use store instead of swap

    @aqrln
    aqrln committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    71e54b4 View commit details
    Browse the repository at this point in the history

  3. Add test

    @aqrln
    aqrln committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    6cde7b1 View commit details
    Browse the repository at this point in the history

  4. Only run test with driver adapters

    @aqrln
    aqrln committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5f72dde View commit details
    Browse the repository at this point in the history

  5. Change order of operations in commit and rollback

    @aqrln
    aqrln committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a66a019 View commit details
    Browse the repository at this point in the history

  6. Clarify wording a bit

    @aqrln
    aqrln committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5ab9f4f View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Change only tag from generic JS to libsql.js 

    Co-authored-by: Miguel Fernández <[email protected]>
    @aqrln
    aqrln and Miguel Fernández authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    3948956 View commit details
    Browse the repository at this point in the history

  2. Relax ordering mode of TransactionProxy::closed modifications 

    There's no need in release-store in commit/rollback and acquire-load in
destructor anymore since we don't care for commit to have finished in
the destructor anymore.
    @aqrln
    aqrln committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    96e9ec8 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Fix the exclude tag

    @aqrln
    aqrln committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    8e0f716 View commit details
    Browse the repository at this point in the history