feat(driver-adapters): enable Wasm on sql-query-connector
#4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asm32-unknown-unknown compilation
jkomyno
commented
Nov 14, 2023
query-engine/connectors/sql-query-connector/src/database/mod.rs
Outdated
Show resolved
Hide resolved
jkomyno
commented
Nov 14, 2023
Comment on lines
+23
to
+31
| #[cfg(target_arch = "wasm32")] | ||
| macro_rules! trace { | ||
| (target: $target:expr, $($arg:tt)+) => {{ | ||
| // No-op in WebAssembly | ||
| }}; | ||
| ($($arg:tt)+) => {{ | ||
| // No-op in WebAssembly | ||
| }}; | ||
| } |
There was a problem hiding this comment.
trace! macro for wasm32-*
jkomyno
commented
Nov 14, 2023
Comment on lines
+33
to
+41
| #[cfg(not(target_arch = "wasm32"))] | ||
| macro_rules! trace { | ||
| (target: $target:expr, $($arg:tt)+) => { | ||
| tracing::log::trace!(target: $target, $($arg)+); | ||
| }; | ||
| ($($arg:tt)+) => { | ||
| tracing::log::trace!($($arg)+); | ||
| }; | ||
| } |
There was a problem hiding this comment.
trace! macro for native compilation.
CodSpeed Performance ReportMerging #4444 will degrade performances by 5.92%Comparing Summary
Benchmarks breakdown
|
…github.com:prisma/prisma-engines into feat/sql-query-connector-on-wasm32-unknown-unknown
…ery-connector-on-wasm32-unknown-unknown
jkomyno
requested review from
miguelff and
Druue
and removed request for
a team
…github.com:prisma/prisma-engines into feat/sql-query-connector-on-wasm32-unknown-unknown
miguelff
approved these changes
Nov 17, 2023
| tracing = "0.1" | ||
| tracing-futures = "0.2" | ||
| uuid.workspace = true | ||
| opentelemetry = { version = "0.17", features = ["tokio"] } | ||
| tracing-opentelemetry = "0.17.3" | ||
| quaint.workspace = true | ||
| quaint = { path = "../../../quaint" } |
There was a problem hiding this comment.
Are these to prevent feature unification?
There was a problem hiding this comment.
Yes, but I spotted a problem while running the CI for request-handlers.
I'm cherry-picking 96cd8ca here.
There was a problem hiding this comment.
(This indeed fixed the CI tests)
Base automatically changed from
feat/quaint-on-wasm32-unknown-unknown
to
main
November 17, 2023 15:22
jkomyno
deleted the
feat/sql-query-connector-on-wasm32-unknown-unknown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes https://github.com/prisma/team-orm/issues/283, and depends on #4442.