Unskip tests for driver adapters core features, skip tests for low fidelity cases #4400
Conversation
CodSpeed Performance ReportMerging #4400 will not alter performanceComparing Summary
|
miguelff
force-pushed
the
mff/472
branch
2 times, most recently
from
03e0d0a
to
67a2559
Compare
…type error in one similar to rust
| - name: 'planetscale' | ||
| setup_task: 'dev-planetscale-vitess8' |
There was a problem hiding this comment.
Intentionally dropping something that is currently in main?
There was a problem hiding this comment.
Yes, this doesn't provide any value at all until fituring out the vitess test situation for driver adapters. Which has it's own issue. As of now, the feedback on this test suite doesn't provide any kind of value.
BTW: PS tests pass on prisma/prisma, but I expect a lot of tests broken for planetscale in the engines.
| runner, | ||
| r#"query { findManyTestModel { field } }"#, | ||
| 2023, | ||
| "Inconsistent column data: Conversion failed: number must be an integer in column 'field'" |
There was a problem hiding this comment.
We can not easily make this error message similar to the Quaint one?
(It's fine, just and error edge case, but double checking as of course less variants would be better)
There was a problem hiding this comment.
Not exactly the same. No.
| // The following tests are excluded for driver adapters. The underlying | ||
| // driver rejects queries where the values of the positional arguments do | ||
| // not match the expected types. As an example, the following query to the | ||
| // driver |
There was a problem hiding this comment.
Does that mean that our raw query API with driver adapters is less accepting than our Rust one?
(Not a problem at all, just interesting)
There was a problem hiding this comment.
Yes, it's a little bit more strict.
|
This merge commit will fail, because it requires changes from prisma/prisma#21889, it's OK. |
Closes https://github.com/prisma/team-orm/issues/472
Closes https://github.com/prisma/team-orm/issues/520
Sibling to prisma/prisma#21889