Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js-connectors): improve debug experience on conversion's panics #4175

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Aug 28, 2023

…by adding references to the column name involved.

This PR was added after a conversation with @janpio and his feedback about the debug DX of JS Connectors.

…y adding references to the column name involved
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2023

CodSpeed Performance Report

Merging #4175 will not alter performance

Comparing feat/js-connectors-panic-debug-dx (12fc0c9) with main (1c5aa64)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@jkomyno jkomyno marked this pull request as ready for review August 31, 2023 11:23
@jkomyno jkomyno requested a review from a team as a code owner August 31, 2023 11:23
@jkomyno jkomyno merged commit fe418f5 into main Aug 31, 2023
29 of 30 checks passed
@jkomyno jkomyno deleted the feat/js-connectors-panic-debug-dx branch August 31, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants