Add integration test for connecting to SQL DBs with IPv6 address in URL #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4077 will improve performances by 5.03%Comparing Summary
Benchmarks breakdown
|
aqrln
force-pushed
the
integration/ipv6-with-tests
branch
2 times, most recently
from
4f2d5ad
to
e3c036a
Compare
aqrln
changed the title
Add an integration test for connecting to SQL databases with an IPv6 address in a connection string. This serves as a regression test for the fix for PostgreSQL and MySQL in 1548dc1, as well as confirms that this already works on MS SQL. Ref: #4051 Ref: prisma/prisma#18079
aqrln
force-pushed
the
integration/ipv6-with-tests
branch
from
e3c036a
to
259c2f6
Compare
|
was approved in slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
includes the commit from #4051 (to run the full CI including Buildkite)(UPD: original PR merged) and the integration test for IPv6 URLs for the schema engine.Adding a similar integration test in the query engine seems to be a little more involved given how its test setup works (with connection strings being built dynamically, and using domain names from docker network rather than
localhostor127.0.0.1on CI). It's certainly possible but I'm not sure is worth the effort given that the change was purely in quaint, and affects both engines in the same way.A test for MongoDB wasn't added as it is currently blocked by mongodb/mongo-rust-driver#916, it needs to be implemented upstream first.