Skip to content

Commit

Permalink
Revert "fix(ci): fix schema-engine for SQL Server 2017"
Browse files Browse the repository at this point in the history
This reverts commit 5aebbbf.
  • Loading branch information
jkomyno committed Sep 23, 2024
1 parent 6947641 commit 7aa8534
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-query-engine-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
required: true
ubuntu:
type: string
default: 'latest'
required: true
single_threaded:
type: boolean
default: false
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-query-engine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,10 @@ jobs:
database:
- name: "mssql_2022"
version: "2022"
ubuntu: "latest"
- name: "mssql_2019"
version: "2019"
ubuntu: "latest"
- name: "mssql_2017"
version: "2017"
ubuntu: "20.04"
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/test-schema-engine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ jobs:
database:
- name: mssql_2017
url: "sqlserver://localhost:1434;database=master;user=SA;password=<YourStrong@Passw0rd>;trustServerCertificate=true;socket_timeout=60;isolationLevel=READ UNCOMMITTED"
ubuntu: "20.04"
- name: mssql_2019
url: "sqlserver://localhost:1433;database=master;user=SA;password=<YourStrong@Passw0rd>;trustServerCertificate=true;socket_timeout=60;isolationLevel=READ UNCOMMITTED"
- name: mssql_2022
Expand Down Expand Up @@ -105,7 +104,7 @@ jobs:
is_vitess: true
single_threaded: true

runs-on: "ubuntu-${{ matrix.database.ubuntu || 'latest' }}"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions-rust-lang/setup-rust-toolchain@v1
Expand Down

0 comments on commit 7aa8534

Please sign in to comment.