Skip to content

Commit

Permalink
Run planetscale adapters for all tests that don't exclude vitess
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelff committed Nov 6, 2023
1 parent 16679d0 commit 662c7bb
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,9 @@ pub(crate) fn should_run(
.any(|only| ConnectorVersion::try_from(*only).unwrap().matches_pattern(&version));
}

if CONFIG.external_test_executor().is_some() && exclude.iter().any(|excl| excl.0.to_uppercase() == "JS") {
let running_driver_adapters = CONFIG.external_test_executor().is_some();

if running_driver_adapters && exclude.iter().any(|excl| excl.0.to_uppercase() == "JS") {
println!("Excluded test execution for JS driver adapters. Skipping test");
return false;
};
Expand All @@ -316,7 +318,7 @@ pub(crate) fn should_run(

// FIXME: This skips vitess unless explicitly opted in. Replace with `true` when fixing
// https://github.com/prisma/client-planning/issues/332
!matches!(version, ConnectorVersion::Vitess(_))
running_driver_adapters || !matches!(version, ConnectorVersion::Vitess(_))
}

impl TryFrom<(&str, Option<&str>)> for ConnectorVersion {
Expand Down

0 comments on commit 662c7bb

Please sign in to comment.