feat: 📦 Support ESLint 8 (#431)

BREAKING CHANGE:
Requires ESLint 8. ESLint 8 API changes caused the format function to now be asynchronous.
Requires minimum Node 12 as required by ESLint 8

.all-contributorsrc

@@ -231,6 +231,15 @@
         "code",
         "maintenance"
       ]
+    },
+    {
+      "login": "idahogurl",
+      "name": "Rebecca Vest",
+      "avatar_url": "https://avatars.githubusercontent.com/u/10620169?v=4",
+      "profile": "https://campcode.dev/",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "repoType": "github",

.eslintrc.js

@@ -1,14 +1,16 @@
 const config = {
-  extends: ["kentcdodds", "kentcdodds/jest"],
+  extends: ['kentcdodds', 'kentcdodds/jest'],
   rules: {
-    "max-len": "off",
-    "import/max-dependencies": "off",
-    "space-before-function-paren": [
-      "error",
+    quotes: ['error', 'single', { avoidEscape: true }],
+    'arrow-parens': ['error', 'as-needed'],
+    'max-len': 'off',
+    'import/max-dependencies': 'off',
+    'space-before-function-paren': [
+      'error',
       {
-        anonymous: "never",
-        named: "never",
-        asyncArrow: "always"
+        anonymous: 'never',
+        named: 'never',
+        asyncArrow: 'always'
       }
     ]
   }

__mocks__/glob.js

@@ -63,7 +63,7 @@ module.exports = jest.fn(function mockGlob(globString, options, callback) {
   } else {
     throw new Error(
       `Your test globString: "${globString}"` +
-        ` doesn't have associated mock data.`
+        " doesn't have associated mock data."
     );
   }
 });

__mocks__/prettier-eslint.js

@@ -11,9 +11,9 @@ const format = jest.fn(({ text, filePath = '' }) => {
   } else if (filePath.includes('eslint-config-error')) {
     throw new Error('Some weird eslint config error');
   } else if (filePath.includes('no-change')) {
-    return text;
+    return Promise.resolve(text);
   }
-  return `MOCK_OUTPUT for ${filePath || 'stdin'}`;
+  return Promise.resolve(`MOCK_OUTPUT for ${filePath || 'stdin'}`);
 });
 
 export default format;

babel.config.js

@@ -4,7 +4,7 @@ const config = {
       '@babel/preset-env',
       {
         targets: {
-          node: '8'
+          node: '12'
         },
         useBuiltIns: 'usage',
         corejs: 3

cli-test/override-config.js

@@ -0,0 +1,5 @@
+module.exports = {
+  rules: {
+    quotes: ['error', 'double']
+  }
+};

cli-test/tests/index.js

@@ -71,6 +71,27 @@ test('formats files and outputs to stdout', async () => {
   );
 });
 
+test('handles --eslint-config-path', async () => {
+  // can't just do the testOutput function here because
+  // the output is in an undeterministic order
+  const stdout = await runPrettierESLintCLI(
+    `cli-test/fixtures/stdout1.js --no-eslint-ignore --no-prettier-ignore --eslint-config-path ${__dirname}/../override-config.js`
+  );
+  expect(stdout).toContain(
+    stripIndent(
+      `
+        import baz, { stuff } from "fdjakfdlfw-baz";
+
+        export { bazzy };
+
+        function bazzy(something) {
+          return baz(stuff(something));
+        }
+      `
+    ).trim()
+  );
+});
+
 test('list different files with the --list-different option', async () => {
   // can't just do the testOutput function here because
   // the output is in an undeterministic order
@@ -96,8 +117,8 @@ test(`prettier-eslint ${writeCommand}`, async () => {
   const example1Path = path.resolve(__dirname, '../fixtures/example1.js');
   const example2Path = path.resolve(__dirname, '../fixtures/example2.js');
   try {
-    const example1 = `const {  example1  }  =  baz.bar`;
-    const example2 = `function example2(thing){return thing;};;;;;;;;;`;
+    const example1 = 'const {  example1  }  =  baz.bar';
+    const example2 = 'function example2(thing){return thing;};;;;;;;;;';
     await Promise.all([
       pWriteFile(example1Path, example1),
       pWriteFile(example2Path, example2)

package.json

@@ -4,7 +4,7 @@
   "description": "CLI for prettier-eslint",
   "main": "dist/no-main.js",
   "engines": {
-    "node": ">=8"
+    "node": ">=12.22"
   },
   "bin": {
     "prettier-eslint": "dist/index.js"
@@ -30,7 +30,7 @@
     "chalk": "^2.4.2",
     "common-tags": "^1.8.0",
     "core-js": "^3.1.4",
-    "eslint": "^5.0.0",
+    "eslint": "^8.14.0",
     "find-up": "^4.1.0",
     "get-stdin": "^7.0.0",
     "glob": "^7.1.4",
@@ -39,7 +39,7 @@
     "lodash.memoize": "^4.1.2",
     "loglevel-colored-level-prefix": "^1.0.0",
     "messageformat": "^2.2.1",
-    "prettier-eslint": "^9.0.0",
+    "prettier-eslint": "^14.0.3",
     "rxjs": "^6.5.2",
     "yargs": "^13.2.4"
   },
@@ -53,7 +53,7 @@
     "ajv": "^6.10.0",
     "all-contributors-cli": "^6.7.0",
     "babel-jest": "^24.8.0",
-    "eslint-config-kentcdodds": "14.3.3",
+    "eslint-config-kentcdodds": "^20.2.0",
     "husky": "^2.4.1",
     "jest": "^24.8.0",
     "jest-cli": "^24.8.0",

src/format-files.js

@@ -13,9 +13,6 @@ import findUp from 'find-up';
 import memoize from 'lodash.memoize';
 import indentString from 'indent-string';
 import getLogger from 'loglevel-colored-level-prefix';
-import ConfigFile from 'eslint/lib/config/config-file';
-import Linter from 'eslint/lib/linter';
-import Config from 'eslint/lib/config';
 import * as messages from './messages';
 
 const LINE_SEPERATOR_REGEX = /(\r|\n|\r\n)/;
@@ -69,11 +66,9 @@ function formatFilesFromArgv({
   };
 
   if (eslintConfigPath) {
-    const configContext = new Config({}, new Linter());
-    prettierESLintOptions.eslintConfig = ConfigFile.load(
-      eslintConfigPath,
-      configContext
-    );
+    prettierESLintOptions.eslintConfig = {
+      overrideConfigFile: eslintConfigPath
+    };
   }
 
   const cliOptions = { write, listDifferent };
@@ -94,7 +89,10 @@ function formatFilesFromArgv({
 async function formatStdin(prettierESLintOptions) {
   const stdinValue = (await getStdin()).trim();
   try {
-    const formatted = format({ text: stdinValue, ...prettierESLintOptions });
+    const formatted = await format({
+      text: stdinValue,
+      ...prettierESLintOptions
+    });
     process.stdout.write(formatted);
     return Promise.resolve(formatted);
   } catch (error) {
@@ -238,9 +236,13 @@ function getFilesFromGlob(
 function formatFile(filePath, prettierESLintOptions, cliOptions) {
   const fileInfo = { filePath };
   let format$ = rxReadFile(filePath, 'utf8').pipe(
-    map(text => {
+    mergeMap(async text => {
       fileInfo.text = text;
-      fileInfo.formatted = format({ text, filePath, ...prettierESLintOptions });
+      fileInfo.formatted = await format({
+        text,
+        filePath,
+        ...prettierESLintOptions
+      });
       fileInfo.unchanged = fileInfo.text === fileInfo.formatted;
       return fileInfo;
     })

src/messages.js

@@ -5,20 +5,20 @@ const mf = new MessageFormat('en');
 export { success, failure, unchanged };
 
 function success(data) {
-  const files = `{count, plural, one{file} other{files}}`;
+  const files = '{count, plural, one{file} other{files}}';
   return mf.compile(
     `{success} formatting {countString} ${files} with prettier-eslint`
   )(data);
 }
 
 function failure(data) {
-  const files = `{count, plural, one{file} other{files}}`;
+  const files = '{count, plural, one{file} other{files}}';
   return mf.compile(
     `{failure} formatting {countString} ${files} with prettier-eslint`
   )(data);
 }
 
 function unchanged(data) {
-  const files = `{count, plural, one{file was} other{files were}}`;
+  const files = '{count, plural, one{file was} other{files were}}';
   return mf.compile(`{countString} ${files} {unchanged}`)(data);
 }

src/parser.js

@@ -133,7 +133,6 @@ const parser = yargs
     },
     'jsx-bracket-same-line': {
       type: 'boolean',
-      default: undefined,
       describe: oneLine`
         Put the > of a multi-line JSX element at
         the end of the last line instead of