Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
luckytyphlosion — 06/16/2019
okay so this is how a common symbol is defined:
size <= 4: ALIGN by 4
4 < size <= 8: ALIGN by 8
size > 8: ALIGN by 16
then, define the symbol
you can't simply replace it with a section like common_data because it doesn't align correctly
it'll only align by 4
however, considering that ramscrgen just reads from the object file and manually outputs the symbols in the order they're defined based on common syms
you could probably make common_data anyway, but repurpose ramscrgen to fix the alignment of common_data symbols
and this would mean no common_syms/
Discord contact info
luckytyphlosion