Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Moon Ball bug documentation #1133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct Moon Ball bug documentation #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/bugs_and_glitches.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,10 +1100,16 @@ This can occur if your party and current PC box are both full when you start the

### Moon Ball does not boost catch rate

The Moon Ball checks the wrong memory address for the wrong item ID, so no Pokémon can receive the boost.

**Fix:** Edit `MoonBallMultiplier` in [engine/items/item_effects.asm](https://github.com/pret/pokecrystal/blob/master/engine/items/item_effects.asm):

```diff
-; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
inc hl
- inc hl
- inc hl

push bc
ld a, BANK("Evolutions and Attacks")
call GetFarByte
Expand All @@ -1113,6 +1119,7 @@ This can occur if your party and current PC box are both full when you start the
ret nz
```

Note that this fix only accounts for Pokémon that evolve via Moon Stone as their first evolution method. However, that is sufficient to cover all Pokémon in the game that can evolve by Moon Stone.

### Love Ball boosts catch rate for the wrong gender

Expand Down
2 changes: 1 addition & 1 deletion engine/items/item_effects.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,11 +913,11 @@ MoonBallMultiplier:
pop bc
ret nz

; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
inc hl
inc hl
inc hl

; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
push bc
ld a, BANK("Evolutions and Attacks")
call GetFarByte
Expand Down