Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unreachable client error #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

donasiv
Copy link

@donasiv donasiv commented Dec 5, 2018

When some hosts from a group are unreachable, sup actually exits on the first SSH error. I propose the option flag "ignore-error" that just logs (instead return) when an host is not reachable.

Copy link
Collaborator

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the host from the Supfile .. or filter it out in the CLI right now:

sup --except failing-host.com

EDIT: I'd rather not introduce new options. "Error" is too vague term for ignoring the SSH connection failures only (which ones?).

@donasiv
Copy link
Author

donasiv commented Dec 5, 2018

In my case, I don't want (and cannot) modify the Supfile and/or CLI calls on the fly.
At the moment, I cannot use sup to perform automatic admin operation on a pool of servers, since it fails each time one host goes down. Classic ssh errors: no route to host, connection refused, connection timeout.
That's why I suggest a flag to bypass and log connection issues and run commands on the up and running hosts.

@VojtechVitek
Copy link
Collaborator

@donasiv Could you use inventory command and get list of active servers only?

@donasiv
Copy link
Author

donasiv commented Dec 5, 2018

I thought about it.
But in my case (again), the inventory list will rely on a monitoring tool running on an host administrated by sup itself. That's not secure at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants