Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trending bookmarks listing #20

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

Lucieo
Copy link
Contributor

@Lucieo Lucieo commented Sep 18, 2023

Issue
#7

Description

  • Keep only 1 call for listing in Team (getTeamBookmarksNotInDigest was not required as getTeamBookmarks enabled args to get only bookmarks not in digests)

Screenshot
Delete button for link bookmarked several times by team users
image

Delete button for link bookmarked one time by team users
image

Links bookmarked several times we display a tooltip with names and date of users bookmarking actions
image

User cannot add several same link in same team several times
image

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digestclub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 9:20am

@Lucieo Lucieo force-pushed the feat/7-highlight-trending-bookmark branch from 2c37c63 to e63cef6 Compare September 18, 2023 15:20
@Lucieo
Copy link
Contributor Author

Lucieo commented Sep 18, 2023

Conflicts fixed

@baptadn
Copy link
Member

baptadn commented Sep 19, 2023

Thanks!
Can we improve the look of the version popover ?
Like removing the padding bottom, justify content with space between:
image

Copy link
Member

@baptadn baptadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I drop a bookmark, I get this error:

image

Copy link
Member

@baptadn baptadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Lucieo Lucieo merged commit eedb0ba into main Sep 19, 2023
3 checks passed
@baptadn baptadn deleted the feat/7-highlight-trending-bookmark branch October 4, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants