Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks list switch #10

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Bookmarks list switch #10

merged 1 commit into from
Sep 12, 2023

Conversation

Lucieo
Copy link
Contributor

@Lucieo Lucieo commented Sep 12, 2023

Issue
#4

Screenshot
Mobile
image

Desktop
image

Checked state
image

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
digestclub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 9:48am

Copy link
Member

@baptadn baptadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Lucieo Lucieo merged commit 0e22448 into main Sep 12, 2023
3 checks passed
@mrnossiom
Copy link
Contributor

Hey 👋🏻,

Both in production and in dev with latest changes, I get this:
image
image
which is not as nice as what was proposed in the issue's original message, and IMHO has too little contrast when unchecked. It isn't quite aligned either.

I know the behavior when there are no bookmarks is to hide the paging component, but this creates a weird shift when you have no bookmarks left in your stash. Maybe, this behavior could be changed to display a disabled paging component.

@baptadn baptadn deleted the feat/4-all-bookmarks-switch branch October 4, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants