Tests: Functional tests for OpenRTB battr strict logic #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
approved these changes
Oct 23, 2024
19 tasks
osulzhenko
changed the base branch from
master
to
bugfix/update-openrtb-blocking-battr-logic
…into functional-tests/strict-media-type
osulzhenko
changed the title
osulzhenko
changed the title
marki1an
requested changes
Nov 5, 2024
| BidRequest.defaultBidRequest | AUDIO_BATTR | ||
| } | ||
|
|
||
| def "PBS shouldn't be able to send original battr ortb2 attribute when default preferred media type specified at request level"() { |
There was a problem hiding this comment.
when the preferred media type doesn't match with attribute type
| @@ -131,6 +134,134 @@ class Ortb2BlockingSpec extends ModuleBaseSpec { | |||
| PBSUtils.randomNumber | BTYPE | |||
| } | |||
|
|
|||
| def "PBS shouldn't be able to send original battr ortb2 attribute when original bidder doesn't contain such type impression"() { | |||
There was a problem hiding this comment.
when bid request imps type doesn't match with attribute type
| BANNER | AUDIO_BATTR | ||
| } | ||
|
|
||
| def "PBS shouldn't be able to send original battr ortb2 attribute when default preferred media type specified at account level"() { |
There was a problem hiding this comment.
when account level preferred media type doesn't match with attribute type
marki1an
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… module
🔧 Type of changes
✨ What's the context?
What's the context for the changes? Are there any
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check