Exclude jupyter notebooks from the pretty-format-json check by default #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortann
changed the title
|
no thanks, if someone wants to exclude particular types they can do so I'm their config rather than making that choice for everyone here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes excluding Jupyter notebooks by default from the pretty-format-json hook.
A recent PR added jupyter notebooks (
.ipynb) files as ajsontype, on the grounds that notebooks are stored as JSON files:pre-commit/identify#401
Whilst this makes sense for the
check-jsonhook, it causes some problems with thepretty-format-hookas described in this comment. Jupyter notebooks are conventionally saved with an indent of 1, whereas the pretty-format-hook uses a default indent of 4.A proposed solution is just to exclude jupyter notebooks from the pretty-format-hook by default, which I think is broadly consistent with previous behaviour before PR above was added.