Handle missing referer in session handler

pradoslaw · Oct 9, 2024 · 0c70fb6 · 0c70fb6
1 parent b2afb0c
commit 0c70fb6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/app/Services/Session/Handler.php b/app/Services/Session/Handler.php
@@ -83,7 +83,10 @@ protected function getDefaultPayload($payload)
                 $payload['path'] = $path === '/' ? $path : ('/' . $path);
             }
             if (\in_array($request->path(), ['ping', 'User/Settings/Ajax'])) {
-                $payload['path'] = \parse_url($request->header('Referer'), \PHP_URL_PATH);
+                $parseUrl = \parse_url($request->header('Referer'), \PHP_URL_PATH);
+                if ($parseUrl) {
+                    $payload['path'] = $parseUrl;
+                }
             }
         }
 

diff --git a/tests/Unit/OnlineUsers/PingTest.php b/tests/Unit/OnlineUsers/PingTest.php
@@ -33,6 +33,27 @@ public function ajaxSettingsIsSavedAsReferer(): void
         $this->assertSame('/Mikroblogi', $this->sessionPath());
     }
 
+    #[Test]
+    public function ignoreEmptyHttpRefererPathEmpty(): void
+    {
+        $this->request('/ping', 'http://localhost:8880/');
+        $this->assertSame('/', $this->sessionPath());
+    }
+
+    #[Test]
+    public function ignoreEmptyHttpRefererPathMissing(): void
+    {
+        $this->request('/ping', 'http://localhost:8880');
+        $this->assertSame('/ping', $this->sessionPath());
+    }
+
+    #[Test]
+    public function ignoreEmptyHttpRefererMissing(): void
+    {
+        $this->request('/ping', '');
+        $this->assertSame('/ping', $this->sessionPath());
+    }
+
     private function sessionPath(): string
     {
         /** @var Handler $handler */