Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #429, stray include of an openssl header was removed #431

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

enaess
Copy link
Contributor

@enaess enaess commented Jun 14, 2023

Must have been something I forgot to remove when I was working on this code. After this change, you pppd compiles without openssl as long as you add the following to the configure script: ./configure --disable-peap --disable-eaptls --without-openssl

@Neustradamus
Copy link
Member

@paulusmack: More one month ago, @enaess has done a fix, what do you think?

@paulusmack
Copy link
Collaborator

paulusmack commented Aug 3, 2023

One day @enaess will write a decent commit message... :)

I think the following is an explanation of what this is all about, but please check and correct. Proposed commit message:


pppd: Fix compilation with openssl disabled

If openssl is disabled at configure time but microsoft extensions are enabled,
we get a compilation error due to an unnecessary include in crypto_ms.c.
This removes the unnecessary include.  With this, pppd compiles without
openssl as long as you add the following arguments to the configure script
invocation:

        --disable-peap --disable-eaptls --without-openssl

Fixes: https://github.com/ppp-project/ppp/issues/429
Signed-off-by: Eivind Næss <[email protected]>

If openssl is disabled at configure time but microsoft extensions are enabled,
we get a compilation error due to an unnecessary include in crypto_ms.c.
This removes the unnecessary include.  With this, pppd compiles without
openssl as long as you add the following arguments to the configure script
invocation:

        --disable-peap --disable-eaptls --without-openssl

Fixes: ppp-project#429
Signed-off-by: Eivind Næss <[email protected]>
@enaess
Copy link
Contributor Author

enaess commented Aug 3, 2023

Done @paulusmack

@paulusmack paulusmack merged commit 59342ab into ppp-project:master Aug 4, 2023
25 checks passed
@enaess enaess deleted the crypto-fix branch December 20, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants