Skip to content

Commit

Permalink
Revert lock path to /var/run/lock
Browse files Browse the repository at this point in the history
lock dir changed on linux from /var/log to /run/pppd/lock with
pppd-2.5.0, which makes pppd fail to start if the distribution does not
pre-create the directory.

This reverts it back to /var/run/lock.

Note the standard path for locks is /var/lock, but there is no
ready-made variable for it and we've always been using /var/run/lock,
so this picks the safer alternative of reverting to something that's
always been working.

Fixes: 66a8c74 ("Let ./configure control the paths for pppd")
Fixes: #419
Signed-off-by: Dominique Martinet <[email protected]>
  • Loading branch information
martinetd committed Oct 6, 2023
1 parent edc1926 commit f373123
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pppd/pathnames.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
#define PPP_PATH_PPPDB PPP_PATH_VARRUN "/pppd2.tdb"

#ifdef __linux__
#define PPP_PATH_LOCKDIR PPP_PATH_VARRUN "/lock"
#define PPP_PATH_LOCKDIR _PATH_VARRUN "/lock"
#else
#ifdef SVR4
#define PPP_PATH_LOCKDIR LOCALSTATEDIR "/spool/locks"
Expand Down

0 comments on commit f373123

Please sign in to comment.