plugins/radius: Avoid buffer-overrun in rc_avpair_tostr for PW_TYPE_D…

…ATE (#506) Closes: #499 Signed-off-by: Jaco Kroon <[email protected]>
ppp-project · Aug 17, 2024 · cb59395 · cb59395
1 parent 04e6b8d
commit cb59395
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pppd/plugins/radius/avpair.c b/pppd/plugins/radius/avpair.c
@@ -699,6 +699,7 @@ int rc_avpair_tostr (VALUE_PAIR *pair, char *name, int ln, char *value, int lv)
 	struct in_addr  inad;
 	unsigned char         *ptr;
 	char		*str;
+	time_t tmptime;
 
 	*name = *value = '\0';
 
@@ -752,8 +753,9 @@ int rc_avpair_tostr (VALUE_PAIR *pair, char *name, int ln, char *value, int lv)
 		break;
 
 	    case PW_TYPE_DATE:
+		tmptime = pair->lvalue;
 		strftime (buffer, sizeof (buffer), "%m/%d/%y %H:%M:%S",
-			  gmtime ((time_t *) & pair->lvalue));
+			  gmtime (&tmptime));
 		strncpy(value, buffer, lv-1);
 		break;