Merge develop into PR #617: Fix incorrect multipart boundaries for plain HTTP #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed linting fixed looping
VShingala
reviewed
Sep 11, 2024
There was a problem hiding this comment.
@saksham-postman Changes looks good but there's a test case that's failing.
|
@VShingala fixed. |
VShingala
requested changes
Sep 12, 2024
| @@ -1,7 +1,7 @@ | |||
| let _ = require('./lodash'), | |||
| path = require('path'); | |||
|
|
|||
| const FORM_DATA_BOUNDARY = '----WebKitFormBoundary7MA4YWxkTrZu0gW', | |||
| const FORM_DATA_BOUNDARY = '--WebKitFormBoundary7MA4YWxkTrZu0gW', | |||
There was a problem hiding this comment.
@saksham-postman It seems we have a reason to keep ---- here. Chrome dev tools uses ---- as starting sequence for boundary.
I think we should keep using ---- instead of just -- for better compatibility.
You can see this issue to see how the boundary can be seen in dev tools for reference. (postmanlabs/postman-app-support#11084).
|
@VShingala @saksham-postman Are we continuing with this PR for fixing this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the latest changes from the
developbranch into the work done in PR #617 (Fix incorrect multipart boundaries for plain HTTP).Changes:
developbranch into the feature branchThis PR is intended to update PR #617 with the latest changes from
develop, ensuring it's up to date with the current state of the project. Once this PR is merged, it will bring PR #617 up to date withdevelop.Related PR: #617 (Fix incorrect multipart boundaries for plain HTTP)
@thinkgruen Please review these changes and let us know if any further modifications are needed.