Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add the v0.13.0 release post #488

Merged
merged 31 commits into from
Oct 10, 2024
Merged

blog: add the v0.13.0 release post #488

merged 31 commits into from
Oct 10, 2024

Conversation

rich-iannone
Copy link
Member

This adds the blog post for the v0.13.0 release of the package.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (06b1408) to head (e9a6a98).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files          42       42           
  Lines        4852     4852           
=======================================
  Hits         4263     4263           
  Misses        589      589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 01:23 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 01:26 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 01:36 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 01:38 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 01:43 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 04:31 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 04:34 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 13:25 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 13:43 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 13:52 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 14:06 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 14:08 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 14:09 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:38 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:41 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:42 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:42 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:50 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 8, 2024 21:51 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 9, 2024 16:02 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 9, 2024 16:03 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 9, 2024 16:12 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 9, 2024 16:36 Destroyed
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really great! One more quick nit, if it's okay. I noticed leading into a few examples, that what people should see in the output is not explained.

For example...

  • "you can do this:" (what is this?)
  • "let's style" (what style should I look for?)
  • "add an assortment of styles to it." (what styles? what should I look for?)
  • "let's use tab_options() here" (to do what? what should I look for?)

Could we tell people specifically what will change (so they know what to look for)? E.g.

  • "You can manually indent STABLE using a CSS string:"
  • "Let's set a grey background fill on the column header, stubhead, and footnotes:" (no need to say you are using tab_style() people will see it, and they have seen tab_style() used several times at this point.)
  • Set an aliceblue background fill on the title, with some font and border adjustments.
  • Set a default honeydew background fill on body values.

(Definitely tweak as needed! I think the key is that people should be able to quickly identify what in the table will change; it's okay to just say the easiest to spot piece.)

Screenshots

image

image

image

image

@github-actions github-actions bot temporarily deployed to pr-488 October 9, 2024 20:46 Destroyed
@github-actions github-actions bot temporarily deployed to pr-488 October 9, 2024 23:22 Destroyed
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo, this looks great! I left a small note on a paragraph that's duplicated above and below an example now. It looks like the top piece just needs to be cut out

Comment on lines 126 to 128
For task #1, a simple `loc.stub()` call in `tab_style()`'s `locations=` argument will be enough to target the entire stub.

Task #2 is more interesting. Like `loc.body()`, `loc.stub()` has a `rows=` argument. Because of that, we can use the same Polars expression to target those rows that belong to the stable isotopes (they are identifiable by having `None` values in the `half_life` column). Once we know about the power of Polars expressions in `rows=`, we realize just how much power we have in targeting our table stylings.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last piece might just be removing this, since it's down below the example now!

@rich-iannone rich-iannone merged commit 3c50f0f into main Oct 10, 2024
13 checks passed
@rich-iannone rich-iannone deleted the docs-blog-v0.13.0 branch October 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants