-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor column selection logic for Polars
#360
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 84.72% 85.74% +1.02%
==========================================
Files 41 41
Lines 4346 4328 -18
==========================================
+ Hits 3682 3711 +29
+ Misses 664 617 -47 ☔ View full report in Codecov by Sentry. |
Shoot, thanks for catching this! It seems like there are three behaviors in the new polars release that broke our current approach (afaict this is just a side-effect of us living on the bleeding edge of
I've opened an issue on polars RE the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the fixes (within 24 hours of the polars release 🤯 ). I hope it's okay, I tweaked a little bit to...
- try and give a detailed error for when a list has things that aren't selectors
- use functools reduce to accumulate selectors
We're going to make a small tweak to our CI, so we can quickly preview the docs builds for PRs off of forks, like this. And then should be able to merge!
Here is the docs preview I've pushed to a branch: https://docs-preview-test--gt-python.netlify.app/articles/intro.html |
@machow and @rich-iannone , everything looks great. It seems the developers from |
Related to #340, pola-rs/polars#16242, pola-rs/polars#16250.
This PR provides a quick fix for the column selection logic in
Polars
. Further investigation may be needed from the team.