Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Add manage content permissions recipe #65

Merged
merged 6 commits into from
May 21, 2024
Merged

Conversation

tnederlof
Copy link
Collaborator

Closes #49

@tnederlof tnederlof self-assigned this May 17, 2024
Copy link
Contributor

@wydsith wydsith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor nits from me :)

content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
content/content-permissions/index.qmd Outdated Show resolved Hide resolved
@tnederlof
Copy link
Collaborator Author

@kmasiello I think this is good to go now, not sure if CI should pass, merge when its all good on your end?

@nealrichardson
Copy link
Contributor

@kmasiello I think this is good to go now, not sure if CI should pass, merge when its all good on your end?

Yeah IDK what's wrong with the GH pages build but I don't see this locally. We probably need to disable it until we sort it out.

@kmasiello
Copy link
Collaborator

It's a shame this has to be 4 distinct recipes. See rstudio/connectapi#267 and posit-dev/posit-sdk-py#194 requesting that adding permissions can flexibly take either a user or group guid. Something that could be improved upon in a later iteration.

@kmasiello kmasiello merged commit cccb80f into main May 21, 2024
1 check failed
@kmasiello kmasiello deleted the tn-add-remove-users-content branch May 21, 2024 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import existing recipe: Add/remove users to content
4 participants