Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JQ required to Action Resource #96

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Add JQ required to Action Resource #96

merged 10 commits into from
Jan 8, 2024

Conversation

Tankilevitch
Copy link
Contributor

@Tankilevitch Tankilevitch commented Jan 4, 2024 •
edited
Loading

Description

Resolves #91

What -

  • Added JQ required to actions
  • Deprecated false value in the user properties required attribute

Why -

  • New Feature
  • Previously the default was false, which isn't aligned with how it was returned from the API, where we returned only the ones that are required, therefor aligned it with how the API handles it, as well as so it won't conflict with the required_jq

How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

@Tankilevitch Tankilevitch changed the title Add JQ required Add JQ required to Action Resource Jan 4, 2024
@Tankilevitch Tankilevitch merged commit c079921 into main Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazhersh pazhersh pazhersh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.7.0] Terraform plan fails to read new dynamic required property in self-service action
2 participants
@Tankilevitch @pazhersh