Ensure that version is not part of the state if not explicitly in the tf file
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
requested changes
Sep 5, 2024
erikzaadi
force-pushed
the
PORT-10295
branch
from
8171c64
to
c157a4d
Compare
Tankilevitch
approved these changes
Sep 5, 2024
Comment on lines
32
to
38
| title = "My Custom Integration with version managed by Terraform" | ||
| installation_app_type = "WEBHOOK" | ||
| # NOTE: This property is by default not used, since it can change outside of terraform | ||
| # Include this only if you explicitly want to control the version with Terraform | ||
| version = "1.33.7" | ||
| config = jsonencode({ | ||
| createMissingRelatedEntitiesboolean = true |
There was a problem hiding this comment.
lets use an actuall real one, like an ocean one, which isn't a webhook
port/integration/schema.go
Outdated
| @@ -73,7 +74,7 @@ Docs about how to import existing integrations and manage their mappings can be | |||
| resource "port_integration" "my_custom_integration" { | |||
| installation_id = "my-custom-integration-id" | |||
| title = "My Custom Integration" | |||
| version = "1.33.7" | |||
| version = "1.33.7" # Optional, can be omitted | |||
erikzaadi
force-pushed
the
PORT-10295
branch
from
9698ba6
to
c027225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - When altering an integrations version outside of terraform, it would affect the state even if not specified in a
port_integrationsectionWhy - Allows updating versions of integrations outside of terraform, keep terraform for updating configuration and mappings
How - Make
versionboth optionable and computedType of change
Please leave one option from the following and delete the rest: