-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automation run created and any run change event trigger support #177
Add automation run created and any run change event trigger support #177
Conversation
…rm-for-automations-run-updated-event-trigger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks very clean :)
port/action/model.go
Outdated
type RunCreatedEvent struct { | ||
ActionIdentifier types.String `tfsdk:"action_identifier"` | ||
} | ||
|
||
type RunUpdatedEvent struct { | ||
ActionIdentifier types.String `tfsdk:"action_identifier"` | ||
} | ||
|
||
type AnyRunChangeEvent struct { | ||
ActionIdentifier types.String `tfsdk:"action_identifier"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type RunCreatedEvent struct { | |
ActionIdentifier types.String `tfsdk:"action_identifier"` | |
} | |
type RunUpdatedEvent struct { | |
ActionIdentifier types.String `tfsdk:"action_identifier"` | |
} | |
type AnyRunChangeEvent struct { | |
ActionIdentifier types.String `tfsdk:"action_identifier"` | |
} | |
type ActionEvent struct { | |
ActionIdentifier types.String `tfsdk:"action_identifier"` | |
} | |
type RunCreatedEvent struct { | |
ActionEvent | |
} | |
type RunUpdatedEvent struct { | |
ActionEvent | |
} | |
type AnyRunChangeEvent struct { | |
ActionEvent | |
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the same can be assigned to Entity<action>EventModel
?
port/action/resource_test.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plase add one import state test as well
…ed-event-type-for-automations
…ed-event-type-for-automations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
What - Add support for the upcoming "run created" and "any run change" automation event types
How - Added the relevant models and schemas to support creating such actions
Type of change
Please leave one option from the following and delete the rest: